Attention is currently required from: Kapil Porwal, Nick Vaccaro, Scott Chao.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Reka Norman, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79244?usp=email
to look at the new patch set (#4).
Change subject: mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC ......................................................................
mb/google/nissa: make GPP_F17 edge triggered to avoid spamming EC
In nissa platform, we configured GPP_F17 as SCI+APIC to wake the system and also generate IRQ to the IOAPIC. Currently, we set GPP_F17 to level triggered and it causes AP (Application Processor) to keep sending GET_NEXT_EVENT to EC during resume from suspend by connecting AC.
So we change GPP_F17 to edge triggered to avoid this condition.
BUG=b:308716748 TEST=Original failure rate was 7 out of 10 times and it reduced to 0 out of 60 times on six joxer systems.
Signed-off-by: Scott Chao scott_chao@wistron.corp-partner.google.com Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff --- M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/79244/4