build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32057 )
Change subject: mediatek/mt8183: Calibrate vsim2 to 2.7 V ......................................................................
Patch Set 11:
(16 comments)
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@73... PS11, Line 732: {0x14A6, 0x10, 0x7f, 0}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@73... PS11, Line 734: {0x14A6, 0x10, 0x7f, 8}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@73... PS11, Line 737: {0x14A4, 0x1, 0x3, 0}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@73... PS11, Line 739: {0x1BC6, 0x38, 0x7f, 0}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@74... PS11, Line 741: {0x1BC6, 0x38, 0x7f, 8}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@74... PS11, Line 744: {0x1BC4, 0x1, 0x3, 0}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@74... PS11, Line 746: {0x134, 0x1, 0x1, 4}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@85... PS11, Line 850: printk(BIOS_ERR, "[%s] Bingo 0x%x = 0x%x\n", __func__, 0x1426, pwrap_read_field(0x1426, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@85... PS11, Line 851: printk(BIOS_ERR, "[%s] Bingo 0x%x = 0x%x\n", __func__, 0x141e, pwrap_read_field(0x141e, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@85... PS11, Line 855: printk(BIOS_ERR, "[%s] SCP Bingo 0x%x = 0x%x\n", __func__, 0x1426, pwrap_read_field(0x1426, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@85... PS11, Line 856: printk(BIOS_ERR, "[%s] SCP Bingo 0x%x = 0x%x\n", __func__, 0x141e, pwrap_read_field(0x141e, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@85... PS11, Line 857: printk(BIOS_ERR, "[%s] SCP Bingo 0x%x = 0x%x\n", __func__, 0x14a4, pwrap_read_field(0x14a4, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@85... PS11, Line 858: printk(BIOS_ERR, "[%s] SCP Bingo 0x%x = 0x%x\n", __func__, 0x14a6, pwrap_read_field(0x14a6, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@85... PS11, Line 859: printk(BIOS_ERR, "[%s] SCP Bingo 0x%x = 0x%x\n", __func__, 0x1bc4, pwrap_read_field(0x1bc4, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@86... PS11, Line 860: printk(BIOS_ERR, "[%s] SCP Bingo 0x%x = 0x%x\n", __func__, 0x1bc6, pwrap_read_field(0x1bc6, 0xFFFF, 0)); line over 80 characters
https://review.coreboot.org/#/c/32057/11/src/soc/mediatek/mt8183/mt6358.c@86... PS11, Line 861: printk(BIOS_ERR, "[%s] SCP Bingo 0x%x = 0x%x\n", __func__, 0x134, pwrap_read_field(0x134, 0xFFFF, 0)); line over 80 characters