Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34535 )
Change subject: lib: Call extract() only when initrd.size is more than 0
......................................................................
Patch Set 2:
This seems like a bug somewhere else, I'm not convinced we should handle this. Either you want an initrd and it will have a non-zero size, or you don't want an initrd and config->ramdisk shouldn't be set at all. A FIT image that includes a zero-length initrd sounds invalid to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34535
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85aa33d2c2846b6b3a58df834dda18c47433257d
Gerrit-Change-Number: 34535
Gerrit-PatchSet: 2
Gerrit-Owner: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jul 2019 19:50:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment