Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32339 )
Change subject: mediatek/mt8183: Enable RTC eosc calibration feature to save power ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@9 PS1, Line 9: shutdown
EOSC calibration only exist when system shutdown, we should not use EOSC clock directly without calibration. So we want to switch the clock to DCXO earlier because watchdog, BT and other modules might use this clock before kernel RTC init.
Does BT mean Bluetooth? What does the PMIC RTC clock have to do with Bluetooth? And are we actually using the PMIC watchdog for anything? (I assume this is different from the AP watchdog?) We generally only want one hardware watchdog on the system, otherwise they'll just get in each other's way.
We implement psci system_off function in ATF which contains some PMIC settings and RTC alarm settings.
Do you not have an RTC/PMIC driver in the kernel. Also, what RTC alarm stuff do you have in TF? That really sounds like something that should only be in the kernel.