Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31216 )
Change subject: sb/amd/agesa/hudson/Kconfig: Disable xHCI by default if no USE_BLOBS
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
This is an improvement. Though, I still don't see why
you insist on the indirect relation.
https://review.coreboot.org/#/c/31216/1/src/southbridge/amd/agesa/hudson/Kco...
File src/southbridge/amd/agesa/hudson/Kconfig:
https://review.coreboot.org/#/c/31216/1/src/southbridge/amd/agesa/hudson/Kco...
PS1, Line 41: default y if USE_BLOBS
Why `USE_BLOBS`? why not make it explicit that this
is related to `HUDSON_XHCI_FWM`? or, why should only
one that selects `USE_BLOBS` get a sane default but
somebody that selects `HUDSON_XHCI_FWM` not?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31216
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c3f0ff49fbe3db3ef095d99055f75d65cd6f661
Gerrit-Change-Number: 31216
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Comment-Date: Sun, 03 Feb 2019 11:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
