Attention is currently required from: Felix Singer, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53925 )
Change subject: soc/intel/skylake: Set proper defaults in chipset devicetree
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/skylake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/53925/comment/ac56890f_bbe609f0
PS1, Line 63: n end # P2SB
: device pci 1f.2 alias pmc on
I'm not sure if we should have P2SB unhidden by default. It is usually hidden and FSP will hide it anyway depending on upd `SbAccessUnlock`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20b8cbe536da70fccc3d11e1eedf4a5e14bfc862
Gerrit-Change-Number: 53925
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 08 May 2021 10:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment