Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: drivers/emulation/qemu: Show splashscreen on bochs VGA ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34599/2/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/34599/2/src/device/Kconfig@450 PS2, Line 450: It might not be implemented for every framebuffer initialization platform. I don't see why. See comment in src/drivers/emulation/qemu/bochs.c
https://review.coreboot.org/c/coreboot/+/34599/2/src/drivers/emulation/qemu/... File src/drivers/emulation/qemu/bochs.c:
https://review.coreboot.org/c/coreboot/+/34599/2/src/drivers/emulation/qemu/... PS2, Line 126: if (CONFIG(BOOTSPLASH)) implement a platform independent bootsplash driver instead of modifying $n places in coreboot. That can easily done with BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, ...