5 Aug
2019
5 Aug
'19
3:54 p.m.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34685 )
Change subject: drivers/fsp1_1/raminit: fix use of mrc_hob ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34685/3/src/drivers/intel/fsp1_1/ra... File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/c/coreboot/+/34685/3/src/drivers/intel/fsp1_1/ra... PS3, Line 262: if (mrc_hob == NULL)
no, this is about the use of the mrc_hob, not the display of its contents
IMO this print is related to Hob information (hob present or not) I can live with your patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/34685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01f6d1d6dfd10297b30de638301c5e0b6545da9c
Gerrit-Change-Number: 34685
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Aug 2019 13:54:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Gerrit-MessageType: comment