Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 )
Change subject: src/arch/x86: Use core apic id to get cpu_index()
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/26346/12/src/arch/x86/cpu.c
File src/arch/x86/cpu.c:
https://review.coreboot.org/#/c/26346/12/src/arch/x86/cpu.c@314
PS12, Line 314: #if CONFIG(PARALLEL_MP)
Looks like few mainboard doesn't select this config hence mp_get_apic_id() function is undefined whi […]
Why is PARALLEL_MP needed as a dependency at all? Just because that's how things currently are? Can't we make it work regardless of PARALLEL_MP being selected? i.e. make src/cpu/x86/lapic/lapic_cpu_init.c work as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350
Gerrit-Change-Number: 26346
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 08 May 2019 18:05:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment