Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35762 )
Change subject: sb/intel/ibexpeak: Implement USB current settings
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp...
File src/southbridge/intel/ibexpeak/early_usb.c:
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp...
PS8, Line 29: const u16 currents[] = { 0xf57, 0xf5f, 0x753, 0x75f,
: 0x14b, 0x74b, 0x557, 0x757,
: 0x55f, 0x54b
please use the 96-character line length limit :D […]
Done
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp...
File src/southbridge/intel/ibexpeak/pch.h:
https://review.coreboot.org/c/coreboot/+/35762/8/src/southbridge/intel/ibexp...
PS8, Line 72: current_lookup_idx
Any clue as to what these mean? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icea9673623a62e7039d5700100a2ee238478abd1
Gerrit-Change-Number: 35762
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 05 Oct 2019 09:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment