[coreboot-gerrit] [S] Change in coreboot[main]: soc/mediatek/mt8196: Add booker driver

[Yidi Lin (Code Review)]

Attention is currently required from: Dehui Sun, Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )

Change subject: soc/mediatek/mt8196: Add booker driver
......................................................................

Patch Set 10:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85362/comment/860f9723_305cfd5c?usp... :
PS10, Line 10: e(
space

https://review.coreboot.org/c/coreboot/+/85362/comment/a95403a0_40e73c40?usp... :
PS10, Line 16:  set bit[3]
it is needed to clear bit 3 (disable_cmo_prop) in por_sbsx_cfg_ctl register of each SBSX node in order to propagate the CMO command.

File src/soc/mediatek/mt8196/booker.c:

https://review.coreboot.org/c/coreboot/+/85362/comment/822b454a_d48bc152?usp... :
PS10, Line 11: OFF_REG_POR_SBSX_CFG_CTL
POR_SBSX_CFG_CTL_OFFSET

https://review.coreboot.org/c/coreboot/+/85362/comment/2f47f3a4_f1f2df4b?usp... :
PS10, Line 25: 64p
I think it is a 32-bit register ?