Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22872 )
Change subject: security/crypto: Add crypto primitives for hashing data ......................................................................
Patch Set 26:
(5 comments)
https://review.coreboot.org/#/c/22872/21/src/security/Kconfig File src/security/Kconfig:
https://review.coreboot.org/#/c/22872/21/src/security/Kconfig@17 PS21, Line 17:
replace all of these with: […]
Done
https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig File src/security/crypto/Kconfig:
https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@15 PS21, Line 15: menu "Cryptographic Primitives" : : config CRYPTO_HASH
Do we need 2 levels of menus?
Done
https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@24 PS21, Line 24: ds on CRYPTO_HA
Do these need to be user selectable, or would they be set from inside another Kconfig?
Done
https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@26 PS21, Line 26: Enable this opti
- Wouldn't 'depends on CRYPTO_HASH' be better? […]
Done
https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@49 PS21, Line 49:
- How is listing what's supported useful? […]
Done