Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40247 )
Change subject: soc/amd/picasso/i2c: don't initialize I2C4 as master and refactor code
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40247/8/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40247/8/src/soc/amd/picasso/i2c.c@9...
PS8, Line 91: ARRAY_SIZE(config->i2c)
Is this wrongly including APU_I2C4_BASE?
I don't think so.
I2C_MASTER_DEV_COUNT = 2.
ARRAY_SIZE(config->i2c) = 4.
It's declared as:
struct dw_i2c_bus_config i2c[I2C_MASTER_DEV_COUNT];
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I397b074ef9c14bf6a4f6680696582f5173a5d0d3
Gerrit-Change-Number: 40247
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Magf -
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Edward Hill
ecgh@chromium.org
Gerrit-Comment-Date: Tue, 07 Jul 2020 23:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward Hill
ecgh@chromium.org
Gerrit-MessageType: comment