Attention is currently required from: Anil Kumar K, Eric Lai, Jérémy Compostella, Nick Vaccaro, Subrata Banik.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78502?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/{google,intel}: Update FMD to support CBFS verification ......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/dedede/chromeos-dedede-16MiB.fmd:
https://review.coreboot.org/c/coreboot/+/78502/comment/b242f810_4cc10e0c : PS3, Line 10: 0x3a27c0 Just remove the length (both here and below) so that FW_MAIN_A/B takes up all the remaining space?
The locations can also be removed if you want. The FMD tool knows where to put things now based on the previous sizes and locations.
File src/mainboard/google/dedede/chromeos-dedede-32MiB.fmd:
https://review.coreboot.org/c/coreboot/+/78502/comment/1f038f75_d3fea341 : PS3, Line 13: 0x3cffc0 Same, just remove the lengths.
File src/mainboard/intel/jasperlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/78502/comment/49fdf67c_57a1db81 : PS3, Line 11: @0x2000 0x3a27c0 You get the idea.