Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Please also add Documentation.
https://review.coreboot.org/#/c/29434/3/src/mainboard/lenovo/x220/variants/x...
File src/mainboard/lenovo/x220/variants/x1/gpio.c:
https://review.coreboot.org/#/c/29434/3/src/mainboard/lenovo/x220/variants/x...
PS3, Line 5: * Copyright (C) 2014 Vladimir Serbinenko
your copyright is missing
--
To view, visit
https://review.coreboot.org/29434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 3
Gerrit-Owner: Bill XIE
persmule@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 03 Nov 2018 10:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes