Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33740 )
Change subject: Documentation: Update soc/intel/apollolake ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/c/coreboot/+/33740/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33740/1//COMMIT_MSG@9 PS1, Line 9: Explaing
Explain
Done
https://review.coreboot.org/c/coreboot/+/33740/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33740/2//COMMIT_MSG@9 PS2, Line 9: Explaing
Explain
Done
https://review.coreboot.org/c/coreboot/+/33740/1/Documentation/soc/intel/apo... File Documentation/soc/intel/apollolake/index.md:
https://review.coreboot.org/c/coreboot/+/33740/1/Documentation/soc/intel/apo... PS1, Line 11: The IFWI region can be manipulated by `ifwitool`.
Do we want to remove this note then?
Done
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... File Documentation/soc/intel/apollolake/index.md:
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... PS3, Line 17: IFWI firmware components
What makes them IFWI firmware components? Aren't they simply `firmware compontents`?
Done
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... PS3, Line 36: To disable dual partitioning mode, set bit3 in IFD at offset `0x1ff` to 1.
0x11f
Done
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... PS3, Line 57: **Including components:**
Included
Done
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... PS3, Line 70:
One blank line is enough?
Done