Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84543?usp=email )
Change subject: mb/google/fatcat/var/fatcat: Add initial FW_CONFIG
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84543/comment/8d6597ba_09324842?usp... :
PS6, Line 37: field STORAGE 15 16
This is okay, but we are not limited to have single storage. For instance, two NVMe at the same time.
what is the motivation of having two SSD working at the same time ?
btw, `STORAGE_UNKNOWN` can be used to boot any storage (like between SSD Gen4 or Gen5)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84543?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5c90aac4873dcc57e65e641656dca3a96f84d6b8
Gerrit-Change-Number: 84543
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-Comment-Date: Sun, 29 Sep 2024 04:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com