Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34929 )
Change subject: arch/x86: Remove spinlocks inside CAR ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34929/3/src/arch/x86/include/arch/s... File src/arch/x86/include/arch/smp/spinlock.h:
https://review.coreboot.org/c/coreboot/+/34929/3/src/arch/x86/include/arch/s... PS3, Line 39: ENV_STAGE_HAS_DATA_SECTION
I agree. I know AGESA fam14 has cache coherency issues. […]
I essentially reverted spinlocks in CAR now.
https://review.coreboot.org/c/coreboot/+/34929/4/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/c/coreboot/+/34929/4/src/console/printk.c@29 PS4, Line 29: if (ENV_STAGE_HAS_DATA_SECTION) : spin_lock(&console_lock); : else if (ENV_ROMSTAGE && CONFIG(HAVE_ROMSTAGE_CONSOLE_SPINLOCK)) : spin_lock(romstage_console_lock());
I meant you can have a helper function here as well: […]
Ack
https://review.coreboot.org/c/coreboot/+/34929/4/src/cpu/amd/pi/00730F01/mic... File src/cpu/amd/pi/00730F01/microcode_fam16h.c:
PS4:
Added in CB:29792 but since CB:29793 was abandoned we only need this file built for ramstage. […]
Ack