[coreboot-gerrit] [S] Change in coreboot[main]: security/vboot: Add Kconfig option to clear recovery request

[Michał Żygowski (Code Review)]

Attention is currently required from: Julius Werner, Yu-Ping Wu.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74343?usp=email )

Change subject: security/vboot: Add Kconfig option to clear recovery request
......................................................................

Patch Set 8:

(2 comments)

File src/security/vboot/bootmode.c:

https://review.coreboot.org/c/coreboot/+/74343/comment/ea2a0b92_d6aaa9e8 :
PS4, Line 68: BS_ON_ENTRY
> CSME-required reboots should be all done at POST_DEVICE, unless CSE LITE has different flow, which I […]

Added the comment as you suggested Yu-Ping Wu.

If POST_DEVICE ON_ENTRY is too early, maybe we could shift the vbnv backup to OS_RESUME_CHECK ON_ENTRY?

File src/security/vboot/bootmode.c:

https://review.coreboot.org/c/coreboot/+/74343/comment/8a12e102_34b7f0e2 :
PS6, Line 59: 	if (!CONFIG(VBOOT_CLEAR_RECOVERY_IN_RAMSTAGE))
> Please wrap the entire thing (including `BOOT_STATE_INIT_ENTRY`) in an `#if` block instead.

Done