Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39430 )
Change subject: edid_fill_fb: Add row_alignment argument ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39430/13/src/include/vbe.h File src/include/vbe.h:
https://review.coreboot.org/c/coreboot/+/39430/13/src/include/vbe.h@114 PS13, Line 114: * Calculate row alignment from given parameters.
It's not actually calculating the row alignment. It just gives a number […]
As there seems to be no progress here, I tried to document this myself. But then realized that we make assumptions here that we can't control. We're dealing with blobs and don't know what they will do. Two counter-examples came to mind: * The blob might not choose a power-of-2 alignment. * It might use longer lines even without alignment, e.g. `h_active = 512`, `scanline_bytes = 768`, how to ever reconstruct that by aligning? The only possible alignment would be 768, but we can't use that with `ALIGN_UP()` as it's not a power of 2. So we'd either have to support arbitrary alignments, then we could simply return `scanline_bytes` here, or keep the current `bytes_per_line` inter- face as alternative to the `row_alignment` one.