Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47757 )
Change subject: soc/intel/block/pmclib.c: Properly guard apm_control() ......................................................................
soc/intel/block/pmclib.c: Properly guard apm_control()
This function is only properly implemented with SMM support.
Change-Id: I9e0fc7433a9226825f5ae4903c0ff2e0162d86ac Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/47757/1
diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 02ca6de..09af749 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -713,7 +713,7 @@
void pmc_set_acpi_mode(void) { - if (!acpi_is_wakeup_s3()) { + if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) { apm_control(APM_CNT_ACPI_DISABLE); } }