25 Apr
2019
25 Apr
'19
2:43 p.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32356 )
Change subject: drivers/usb/ucsi: Add driver to generate UCSI memory region ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32356/1/src/drivers/usb/ucsi/ucsi.c File src/drivers/usb/ucsi/ucsi.c:
https://review.coreboot.org/#/c/32356/1/src/drivers/usb/ucsi/ucsi.c@143 PS1, Line 143: pnp_enable_devices(dev, &ops, ARRAY_SIZE(info), info);
Any reason to use the pnp infrastructure? I think, we have a `generic` […]
UCSI is technically PNP0CA0, but this is a bit silly to be sure.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b7fa19436443bc11a6ebe3ce89cd552cee4d85
Gerrit-Change-Number: 32356
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Thu, 25 Apr 2019 14:43:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment