Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44835 )
Change subject: src/{device,include}: Use PNP_IDX_EN instead of magic number
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44835/2/src/device/pnp_device.c
File src/device/pnp_device.c:
https://review.coreboot.org/c/coreboot/+/44835/2/src/device/pnp_device.c@7
PS2, Line 7: #include <device/pnp.h>
is it intended that device/pnp_def.h is included indirectly via this one?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68590605e261ecaace9f3cea28cfa6ec3b913a8a
Gerrit-Change-Number: 44835
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 22:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment