Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38779 )
Change subject: vboot: push clear recovery mode switch until later ......................................................................
Patch Set 1:
(1 comment)
Moving this to ramstage (and simplifying further, please!) LGTM in general, but I think +Furquan knows what this is good for and what other constraints we might be missing best.
https://review.coreboot.org/c/coreboot/+/38779/1/src/security/vboot/bootmode... File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/38779/1/src/security/vboot/bootmode... PS1, Line 44: vboot_log_and_clear_recovery_mode_switch, NULL); I think this should be combined with google_chromeec_elog_add_recovery_event(). What you're doing right now is creating a CBMEM entry in early ramstage that is then consumed by code later in ramstage. There's no need for those two steps to be separate and for this weird information-passing anymore. Let's just do it all in one go and get rid of one more transient-but-reserved-forever CBMEM region.