Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34778 )
Change subject: soc/mediatek: Change DSI init commands to take flexible length array ......................................................................
Patch Set 13: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui... PS13, Line 132: (const struct lcm_init_command *)panel->init) < 0) { Just change the function to take a (u8 *) instead, you need casts in there anyway.
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel.h:
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui... PS13, Line 27: char u8
https://review.coreboot.org/c/coreboot/+/34778/13/src/mainboard/google/kukui... PS13, Line 36: __VA_ARGS__ Woah... this is one of those "just crazy enough it could work" things. ^^ I thought about packing it better but I didn't think you could make it the tables look that clean in the end. Very neat!
https://review.coreboot.org/c/coreboot/+/34778/13/src/soc/mediatek/common/ds... File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34778/13/src/soc/mediatek/common/ds... PS13, Line 347: buf += sizeof(*init); nit: why not do the whole
buf += sizeof(*init) + len;
at the end?