Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39195 )
Change subject: mb/intel/jasperlake_rvp: Add memory config for Jasper Lake RVP ......................................................................
Patch Set 23:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39195/23/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/board_id.c:
https://review.coreboot.org/c/coreboot/+/39195/23/src/mainboard/intel/jasper... PS23, Line 55: 1F 0x1f
https://review.coreboot.org/c/coreboot/+/39195/23/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39195/23/src/mainboard/intel/jasper... PS23, Line 43: remove
https://review.coreboot.org/c/coreboot/+/39195/23/src/mainboard/intel/jasper... PS23, Line 44: } else { : die("Unsupported Board id : 0x%x\n", board_id); : } isn't this check is duplicate between line #25 above and https://review.coreboot.org/c/coreboot/+/39195/23/src/mainboard/intel/jasper... ?
you can remove this i believe from here ?