Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33764 )
Change subject: soc/amd/picasso: Update all PSP and amdfw.rom building
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33764/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33764/9//COMMIT_MSG@9
PS9, Line 9: comand
command
https://review.coreboot.org/c/coreboot/+/33764/9//COMMIT_MSG@15
PS9, Line 15: See PID #55758.
Maybe: See AMD NDA document #55758
https://review.coreboot.org/c/coreboot/+/33764/9/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/33764/9/src/soc/amd/picasso/Kconfig...
PS9, Line 397: t
Capitalize: "This"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib5e393e74ed60e968959012b6275686167a2d78a
Gerrit-Change-Number: 33764
Gerrit-PatchSet: 9
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Aug 2019 02:05:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment