Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30957 )
Change subject: superio/ite: Add it8528e ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/30957/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30957/5//COMMIT_MSG@12 PS5, Line 12: TODO: Add support for accessing EC space. Update with your plans where to put that?
https://review.coreboot.org/#/c/30957/5/src/superio/ite/it8528e/chip.h File src/superio/ite/it8528e/chip.h:
PS5: If you are going to treat the EC part as a (logically) separate chip, you won't need this.
https://review.coreboot.org/#/c/30957/5/src/superio/ite/it8528e/chip.h@4 PS5, Line 4: * Copyright (C) 2019 Patrick Rudolph patrick.rudolph@9elements.com There is a tendency to only add copyright notes when they make sense. Basically, when you add some creative part (e.g. design a new compo- sition or start something new in general, maybe also when you add some loops or branches to existing code). This also means that copy- right years should only be updated on such creative changes. AIUI, not when you just touch some lines.
Also are you sure about the attribution? I would have expected 9elements here. But it's hard to map the German "Nutzungsrechte" to copyright and the former depends on your contract with them anyway.