[coreboot-gerrit] Change in ...coreboot[master]: mb/samsung/lumpy: Fix MRC raminit

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32682 )

Change subject: mb/samsung/lumpy: Fix MRC raminit
......................................................................

Patch Set 2: Code-Review-1

This likely won't work.

If I looked in the correct place, the MRC blob takes
`spd_data[0]` for every first DIMM per channel with
`spd_address == 0`. This would also explain the other-
wise redundant `dimm_channelx_disabled` settings. Note
that this means it ignores `spd_data[1..3]`.

What we could do is adding a special tag for `spd_
addresses` like the gone 0xf0, but this time in the
devicetree interface. e.g. for Lumpy:

register "spd_addresses" = "{ 0x50, 0, SPD_DATA, 0 }"

It would just tell the wrapper code that this "DIMM"
shouldn't be disabled. With SPD_DATA == 0x80, we could
even save us extra code:

for (i = 0; i < ARRAY_SIZE(pei->spd_addresses); ++i)
            pei->spd_addresses[i] = config->spd_addresses[i] << 1;

would make it 0x00 ^^