Attention is currently required from: Angel Pons, Felix Singer, Martin L Roth, Matt DeVillier, Michael Niewöhner, Tim Wawrzynczak.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75090?usp=email )
Change subject: mb/purism/librem_l1um_v2: Add support for Purism Librem L1UM v2
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/purism/librem_l1um_v2/bootblock.c:
https://review.coreboot.org/c/coreboot/+/75090/comment/c2fd6a83_d5b0b63b :
PS5, Line 23: /*
Does this need to happen on every boot, or just when you need the serial console? […]
Thank you Martin, saved draft but forgot to click "reply"
The BMC also seems to reset the TPM during its own startup, so the failing to wait for it to finish sometimes meant the TPM would disappear and not be visible to the OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75090?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I990f6024d65098a9553d7d1fe7f36614cc55ea19
Gerrit-Change-Number: 75090
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 05 Sep 2023 16:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment