[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Add display driver

[yongqiang niu (Code Review)]

yongqiang niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )

Change subject: mediatek/mt8183: Add display driver
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/#/c/31478/12/src/soc/mediatek/mt8183/include/soc... 
File src/soc/mediatek/mt8183/include/soc/ddp.h:

https://review.coreboot.org/#/c/31478/12/src/soc/mediatek/mt8183/include/soc... 
PS12, Line 58: /* DISP_REG_CONFIG_MMSYS_CG_CON0
             :    Configures free-run clock gating 0
             : 	0: Enable clock
             : 	1: Clock gating  */
> Is this comment for following enums? I can't see the relationship with that

yes.

the bits defined in CG_CON0_DISP_ALL will be clear to 0 in disp_clock_on, 
that will enable these module clock.

https://review.coreboot.org/#/c/31478/12/src/soc/mediatek/mt8183/include/soc... 
PS12, Line 93: /* DISP_REG_CONFIG_MMSYS_CG_CON1
             :    Configures free-run clock gating 1
             : 	0: Enable clock
             : 	1: Clock gating */
> same here - is this related to any of the enums below?

same with the last one