[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Move some initialization from bootblock to verstage

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30331 )

Change subject: google/kukui: Move some initialization from bootblock to verstage
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/30331/9/src/mainboard/google/kukui/verstage.... 
File src/mainboard/google/kukui/verstage.c:

https://review.coreboot.org/#/c/30331/9/src/mainboard/google/kukui/verstage.... 
PS9, Line 26: void verstage_mainboard_init(void)
Can you wrap all the contents of this function into another function (e.g. mainboard_early_init()), call it from verstage_mainboard_init(), and also add

if (!IS_ENABLED(CONFIG_VBOOT))
   mainboard_early_init();

to the top of platform_romstage_main()? That should make sure people can also run this board without CONFIG_VBOOT.