Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38446 )
Change subject: mb/lenovo/x201: Add support for undock button on X200 ultrabase ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG@7 PS2, Line 7: mb/lenovo/x201: Add support for undock button on X200 ultrabase
mb/lenovo/x201: Support undock button on X200 ultrabase
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG@10 PS2, Line 10: smihandler.c already supported it. One line please. Maybe:
Only the ACPI code needs to be extended, as smihandler.c already supported it. _Q50 is taken from the vendor DSDT.
https://review.coreboot.org/c/coreboot/+/38446/2//COMMIT_MSG@11 PS2, Line 11: Please add the problem description. I have no idea, but something like:
Currently pressing the undock button in Linux 4.… nothing happens, and the device cannot be safely undocked. Now, pressing the button, the LED lights up, and the device can be removed.