Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43002 )
Change subject: cpu/qemu-x86: Fix timestamp and bist reporting
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43002/1//COMMIT_MSG@8
PS1, Line 8:
Why does it not work, though? Where do the correct settings come from?
It doesn't work as the register in assembly are accidentally swapped.
I looked at the code and put in the correct registers. The settings comes from existing assembly code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id66a7f6767735862e138c58c4bcc9e68215dd3c5
Gerrit-Change-Number: 43002
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Jul 2020 06:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment