[coreboot-gerrit] Change in ...coreboot[master]: sb/{ICH7,NM10,PCH}: Use common watchdog_off function

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )

Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function
......................................................................

Patch Set 8:

(3 comments)

Thank you.

https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/tco.h 
File src/southbridge/intel/common/tco.h:

https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/tco.h@3 
PS8, Line 3: *
> Missing Copyright

Done

https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/watchdo... 
File src/southbridge/intel/common/watchdog.c:

https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/watchdo... 
PS8, Line 18: <arch/io.h>
> Why do you need arch/io. […]

Done

https://review.coreboot.org/#/c/32533/8/src/southbridge/intel/common/watchdo... 
PS8, Line 52: <<
> Use define instead of magic value

Done