[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHI...

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33189 )

Change subject: soc/intel/common: Skip SoC GT programming based on CONFIG_SKIP_GRAPHICS_ENABLING
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c 
File src/soc/intel/icelake/graphics.c:

https://review.coreboot.org/#/c/33189/1/src/soc/intel/icelake/graphics.c@48 
PS1, Line 48: DDI_A_4_LANES
> If it gets merged, it adds maintenance burden. If it's only for early […]

It's more of enabling the software to deal with the realities of bringing up new silicon. There is obviously a transition between hobbled and non-hobbled silicon in which there's a logistical problem in supporting everything. It's helpful to have a consistent code base w/ a few knobs vs forking builds and code bases to accommodate the various populations.