Attention is currently required from: Maulik V Vaghela, Sugnan Prabhu S.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55317 )
Change subject: mb/google/brya: Program Unused Cnvi BT related GPIOs to NC
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/55317/comment/983b3bea_9f393677
PS6, Line 368: Put unused Cnvi BT UART lines in NC mode since we use USB mode
Yes Furquan...default state of these vGPIO lines are set to NF1.
Interesting. Do we need to configure all other vGPIOs as NC as well? What is the impact of leaving these at NF1? Power hit? S0ix failures? Functionality issues?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33a37ceb8a91603d2a193de5bdd1b6885eb3c319
Gerrit-Change-Number: 55317
Gerrit-PatchSet: 7
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Comment-Date: Tue, 13 Jul 2021 19:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-MessageType: comment
