Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36943 )
Change subject: Use binaries from Windows installer directly
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
https://review.coreboot.org/c/em100/+/36943/13/em100.c
File em100.c:
https://review.coreboot.org/c/em100/+/36943/13/em100.c@656
PS13, Line 656: static int list_chips_entry(char *name __unused, TFILE *file, void *data __unused, int ok __unused)
It is intended, 0 means continue != 0 means break after this. […]
Ack
--
To view, visit
https://review.coreboot.org/c/em100/+/36943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I8c360e96ce42fd78141a1564976454711e20f527
Gerrit-Change-Number: 36943
Gerrit-PatchSet: 14
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 08:16:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment