Attention is currently required from: Pablo Stebler, Paul Menzel, Iru Cai (vimacs).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after sending
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/ec/hp/kbc1126/ec.c:
https://review.coreboot.org/c/coreboot/+/44750/comment/53767c62_e746ac80
PS4, Line 27: timeout = 0x10000;
The timeout is now 32 times larger, and about 655 ms. […]
After chatting on IRC, I wonder if making this a Kconfig option would make more sense. It would be useful to document that different laptops with different ECs need different timeouts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Gerrit-Change-Number: 44750
Gerrit-PatchSet: 6
Gerrit-Owner: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Pablo Stebler
pablo@stebler.xyz
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Comment-Date: Sun, 31 Jan 2021 11:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment