24 Jan
2021
24 Jan
'21
1:12 p.m.
Attention is currently required from: Subrata Banik, Aaron Durbin. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49616 )
Change subject: soc/intel/common/block/lpc: check DMI SRLOCK before writing LPC registers ......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49616/comment/6f0c6049_96827f9e PS7, Line 10: when DMI SRLOCK is set and print errors accordingly.
Test showed that the locks are reset on reboot. -> No problem here. […]
Subrata, Aaron, any idea what led to the assumption that the lock might already be set in the bootblock (in CB:23866).
--
To view, visit https://review.coreboot.org/c/coreboot/+/49616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5871f03ec61a5181da4a90ae5ac9221ed7a3a96e
Gerrit-Change-Number: 49616
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Sun, 24 Jan 2021 11:12:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment