Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61936 )
Change subject: soc/intel/common/block: Add Kconfig to correct TBT indexing
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/pcie/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/61936/comment/549c69b4_6c045af4
PS3, Line 49: port_num = port_num - 1;
I'm somehow not happy to W/A FSP mistakes in common code. […]
Eventually I want this can solve by TBT FW or FSP. For the schedule reality, we have to accept the WA for this moment. We can remove this after it fixed, WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61936
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f9c3c8e753b982e2ede1a41bf87d6355b82da0f
Gerrit-Change-Number: 61936
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 15 Feb 2022 16:58:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment