Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47559 )
Change subject: intel/fsp2_0: Add soc_validate_fsp_version for FSP version check
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47559/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47559/1//COMMIT_MSG@10
PS1, Line 10: the console is usually ready.
Have about refactoring fsp_print_header_info() to get version string via vsp_get_version(). […]
The usage of fsp_get_version() is to print the version format to a buffer that can be added into coreboot table, while fsp_print_header_info() is meant to print it out on console
I think it's fine to keep fsp_print_header_info() As-is, and CPX can print its own version format in soc_validate_fsp_version().
I make fsp_get_version weak function in CB:47603 and override it in CB:47560.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I628014e05bd567462f50af2633fbf48f3dc412bc
Gerrit-Change-Number: 47559
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Nov 2020 11:35:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment