Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40525 )
Change subject: soc/mediatek/mt8183: High frequency of DRAM should use term settings ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40525/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/40525/1/src/soc/mediatek/mt8183/dra... PS1, Line 278: dramc_mode_reg_write_by_rank(chn, rank, 12, final_vref | ( 0x1 << 6));
space prohibited after that open parenthesis '('
Ack
https://review.coreboot.org/c/coreboot/+/40525/1/src/soc/mediatek/mt8183/dra... PS1, Line 1834: vref_begin = params->tx_vref[chn][rank] | (vref_range << 6) ;
space prohibited before semicolon
Ack
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... PS2, Line 227: dramc_dbg("write leveling[%d][%d][%d] = 0x%x\n", chn0, rk,dqs, wr_level[chn0][rk][dqs]);
line over 96 characters
Ack
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... PS2, Line 227: dramc_dbg("write leveling[%d][%d][%d] = 0x%x\n", chn0, rk,dqs, wr_level[chn0][rk][dqs]);
space required after that ',' (ctx:VxV)
Ack
https://review.coreboot.org/c/coreboot/+/40525/2/src/soc/mediatek/mt8183/dra... PS2, Line 1843: vref_begin = params->tx_vref[chn][rank] | (vref_range << 6) ;
space prohibited before semicolon
Ack