Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41385 )
Change subject: soc/intel/tigerlake: Move PMC PCI resources under PMC device
......................................................................
Patch Set 12:
Patch Set 7: Code-Review+2
Are you planning to push a similar change for JSL?
Also, time to drop PMC PCI_ID from https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/bloc...
Yes, I will do the same treatment for JSL.
Also good catch there, the PCI driver will never bind, so may as well remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7c6ae849aefaf549fb682416a87320907fb3fe3
Gerrit-Change-Number: 41385
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 May 2020 16:39:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment