[coreboot-gerrit] Change in coreboot[master]: eltan/verified_boot: include vboot21 code directly

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37654 )

Change subject: eltan/verified_boot: include vboot21 code directly
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> > > Patch Set 2:
> > >
> > > Hi Frans -- do you have any feedback?  I have a stack of CLs cleaning up the mess of vboot versions that is blocked on this Eltan patch.
> > >
> > > https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_referen...
> >
> > Hi Joel,
> > I will provide an update tomorrow.
>
> We suggest using standard VBoot library and not creating a fork.
> Might be able to replace call to vb21_unpack_key() and vb21_verify_data() to the vb2 variant of these functions.

Hi Frans,

That would work fine, if we can get you switched over to using vboot 2 data structures, and using public functions advertised in 2api.h.  Would that be do-able from your end?

Joel