Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85972?usp=email )
Change subject: mb/starlabs/starlite_adl: Organise the Kconfig options ......................................................................
mb/starlabs/starlite_adl: Organise the Kconfig options
The selected options were a bit illogical, so but them all under the common board Kconfig, alphabetise and dedpulicate them.
Change-Id: I277249323e8735dda0a6e394e475435ddedf5537 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/85972 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starlite_adl/Kconfig 1 file changed, 11 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 0dda164..7791a50 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -1,39 +1,38 @@ config BOARD_STARLABS_STARLITE_SERIES def_bool n select BOARD_ROMSIZE_KB_16384 + select CRB_TPM select DRIVERS_EFI_VARIABLE_STORE - select DRIVERS_OPTION_CFR select DRIVERS_I2C_HID + select DRIVERS_INTEL_PMC + select DRIVERS_OPTION_CFR select EC_STARLABS_CHARGING_SPEED - select EC_STARLABS_LID_SWITCH select EC_STARLABS_ITE + select EC_STARLABS_LID_SWITCH select EC_STARLABS_MAX_CHARGE select EC_STARLABS_MERLIN select EC_STARLABS_NEED_ITE_BIN select EC_STARLABS_POWER_LED select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_INTEL_PTT select HAVE_OPTION_TABLE select HAVE_SPD_IN_CBFS select INTEL_GMA_HAVE_VBT select INTEL_LPSS_UART_FOR_CONSOLE select NO_UART_ON_SUPERIO - select SOC_INTEL_COMMON_BLOCK_HDA_VERB - select SYSTEM_TYPE_DETACHABLE - select VALIDATE_INTEL_DESCRIPTOR - -config BOARD_STARLABS_LITE_ADL - select BOARD_ROMSIZE_KB_16384 - select BOARD_STARLABS_STARLITE_SERIES - select CRB_TPM - select DRIVERS_INTEL_PMC - select HAVE_INTEL_PTT select SOC_INTEL_ALDERLAKE select SOC_INTEL_ALDERLAKE_PCH_N + select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_COMMON_BLOCK_TCSS select SOC_INTEL_CRASHLOG select SPI_FLASH_WINBOND + select SYSTEM_TYPE_DETACHABLE select TPM2 + select VALIDATE_INTEL_DESCRIPTOR + +config BOARD_STARLABS_LITE_ADL + select BOARD_STARLABS_STARLITE_SERIES
if BOARD_STARLABS_STARLITE_SERIES