Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39286 )
Change subject: drivers/generic/max98357a: Allow custom _HID from config
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39286/11/src/drivers/generic/max983...
File src/drivers/generic/max98357a/max98357a.c:
https://review.coreboot.org/c/coreboot/+/39286/11/src/drivers/generic/max983...
PS11, Line 46: if (!config->hid)
: acpigen_write_name_string("_HID", MAX98357A_ACPI_HID);
: else
: acpigen_write_name_string("_HID", config->hid);
I believe Paul meant to just use:
acpigen_write_name_string("_HID", config->hid);
here, and then update all of the devicetrees that use this device to add register "hid" = "MAX98357A_ACPI_HID" (or other as appropriate).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22d2d078a9a4eb6ab330da8439737ff5133086d4
Gerrit-Change-Number: 39286
Gerrit-PatchSet: 11
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Mar 2020 18:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment