Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add Family 15h ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 6: "Clustered MultiThreading" This bugged me before and I didn't say anything. I'd never heard this term used while at AMD, and I suspect it was an afterthought later to try to make a disclaimer for the underwhelming performance. In fact, reading it here was the first I'd ever come across the term.
My preference would be to use the more common terminology of Compute Unit, or CU, to describe each core pair.
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 7: replacing SMT remove
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 8: models This is uncomfortably short now. How about
Family 15h offerings matured into various models with increased performance and features targeting Enterprise, Client, and Embedded designs.
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 15: module Regardless of above, this is certainly called a compute unit and not a module.
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 20: . Could also note that Family 15h comprises 3-chip solutions, 2, and single-chip. Devices designed to contain on-die graphics (i.e. even when they're headless) are commonly referred to as APUs, not CPUs.
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 28: : could delete this
https://review.coreboot.org/c/coreboot/+/34561/9/Documentation/soc/amd/famil... PS9, Line 29: Probably want to remove the space