Attention is currently required from: Bora Guvendik, Jeremy Compostella, Subrata Banik.
Julius Werner has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/87032?usp=email )
Change subject: vc/google/chromeos: Add TPM_GOOGLE config check for logo selection ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87032/comment/f5c4295f_e70417d1?usp... : PS1, Line 10: configuration within the bmp_logo_filename function.
The purpose of the change is for removing Google TPM dependencies in bmp_logo_filename function. […]
Right, and that dependency comes from `chromeos_get_factory_config()`. I think it would be better to decouple this in there.
`tpm_factory_config.c` is probably not a good name for that file anyway because not everything in it is related to TPM (e.g. soft branding isn't). Maybe just rename it to `branding.c` or something like that, make it compiled unconditionally, and then add a line checking for the TPM Kconfig inside `chromeos_get_factory_config()`.