[coreboot-gerrit] Change in coreboot[master]: amdfwtool: Use a variable to get the return value of write

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45812 )

Change subject: amdfwtool: Use a variable to get the return value of write
......................................................................

amdfwtool: Use a variable to get the return value of write

New Jenkins complaint about the original code that return
value gets to nowhere. Fix that with a new variable.

Change-Id: I8099b856ccb751dc380d0e95f5fe319cc3e2c6cc
Signed-off-by: Zheng Bao 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45812
Reviewed-by: Martin Roth 
Reviewed-by: Felix Held 
Tested-by: build bot (Jenkins) 
---
M util/amdfwtool/amdfwtool.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Felix Held: Looks good to me, approved

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index e6341a7..fc352ec 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -1753,7 +1753,12 @@

targetfd = open(output, O_RDWR | O_CREAT | O_TRUNC, 0666);
    if (targetfd >= 0) {
-		write(targetfd, amd_romsig, ctx.current - romsig_offset);
+		ssize_t bytes;
+		bytes = write(targetfd, amd_romsig, ctx.current - romsig_offset);
+		if (bytes != ctx.current - romsig_offset) {
+			fprintf(stderr, "Error: Writing to file %s failed\n", output);
+			retval = 1;
+		}
    	close(targetfd);
    } else {
    	printf("Error: could not open file: %s\n", output);